This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Loop distribution for single nested loops


On Dec 5, 2007 10:41 PM, Diego Novillo <dnovillo@google.com> wrote:
> On 12/5/07 4:13 PM, Sebastian Pop wrote:
> > On Dec 5, 2007 2:53 PM, Richard Guenther <richard.guenther@gmail.com> wrote:
> >> I don't think this is appropriate for mainline at this point.  Absolutely not
> >> if enabled by default.
> >>
> >
> > I don't expect this to be enabled by default and the patch is not
> > enabling by default the distribution, it was just a req from Diego to
> > enable it at -O2 to fix as many bugs during bootstrap and test.
>
> Ah, yes, I remember now.  Thanks.
>
> As it was submitted during stage 2 and it's not enabled by default, I
> think it should be acceptable for 4.3.  However, if Richard does not
> agree, then let's discuss it a bit more.
>
> Maybe Mark has something to say as the RM?  Mark, this is a new loop
> pass that is not enabled by default.  It was submitted during stage 2,
> but the review and feedback was not completed until now.  Should we hold
> it until 4.4?

Well, I'm hesitant to make exceptions (uh, you could argue it's the rule, not
an exception) - and from your requrest for feedback (Oct 3th) to this final
patch there were more than two month.  We're in the third month of stage3.
I'd rather honor people fixing bugs, not people inventing (or finishing) new
passes at this point ;)

But, if it doesn't touch generic code and isn't on by default I am not
absolutely
100% against it.  But then I also do not see the need to push it to 4.3.

Thanks,
Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]