Re: [PATCH] Don't hardcode the makefile name in config-ml.in

[Paolo Bonzini <bonzini at gnu dot org>]

> Please try the first patch in
> <http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01183.html>.

The third patch there is okay.

Now on to the first.  First of all, my apologies for approving the wrong 
patch.  I hadn't realized that the modified code was inside a "cat << \EOF".

If I understand correctly, the ${Makefile} in

	  for dir in ${Makefile} $(MULTIDIRS); do \

is just a way to avoid an error if MULTIDIRS is empty but [ -z 
"$(MULTIDIRS)" ] does not get it?  If this is the case, I would prefer 
to have something like

        set fnord $(MULTIDIRS); shift; \
        lib=`${PWD_COMMAND} | sed -e 's,^.*/\([^/][^/]*\)$$,\1,'`; \
        for dir; do \
EOF
cat >>Multi.tem <<EOF
          if [ -f ../$${dir}/$${lib}/${Makefile} ]; then \
EOF
cat >>Multi.tem <<\EOF
            if (cd ../$${dir}/$${lib}; $(MAKE) $(FLAGS_TO_PASS) $(DO)); \
            then true; \
            else exit 1; \
            fi; \
          else true; \
          fi; \
        done; \

Ralf, portability-wise, what do you think?

Paolo