This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: committed: fix MMIX misuse of ggc_alloc_string
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Hans-Peter Nilsson" <hp at bitrange dot com>
- Cc: gcc-patches at gcc dot gnu dot org, tromey at redhat dot com
- Date: Thu, 22 Nov 2007 12:54:05 -0800
- Subject: Re: committed: fix MMIX misuse of ggc_alloc_string
- References: <20071122022029.K85484@dair.pair.com>
On 11/21/07, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> + char *newstr = alloca (len + 2);
> + newstr[0] = '@';
> strcpy (newstr + 1, str);
> *newstr = '@';
not an issue pre say but you are setting newstr[0] twice here.
Thanks,
Andrew Pinski