This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp] OpenMP 3.0 C parser changes
- From: Tom Tromey <tromey at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Henderson <rth at redhat dot com>
- Date: Tue, 13 Nov 2007 13:49:20 -0700
- Subject: Re: [gomp] OpenMP 3.0 C parser changes
- References: <20071113202046.GL5451@devserv.devel.redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Jakub> Committed to gomp-3_0-branch.
Jakub> + error ("collapse argument needs positive constant integer expression");
Before merging back to the trunk, would you mind changing this to pass
an explicit location using %H? Perhaps the start of the expression
would be the best location. Except for the few places where it is
really difficult, I'd like to keep the C parser "%H-clean"; this is
(IMO) more maintainable and generally gives better column information.
In this particular error, maybe collapse should be quoted with %<...%>?
Jakub> + error ("schedule %<auto%> does not take "
Jakub> + "a %<chunk_size%> parameter");
... %H here too.
thanks,
Tom