Re: [PATCH] gcse.c: don't compute a mapping from CUID to INSN

[Jakub Jelinek <jakub at redhat dot com>]

On Fri, Nov 09, 2007 at 11:46:13PM +0100, Steven Bosscher wrote:
> Thus. Don't do useless work in gcse.c.  This saves 2 passes over all
> insns with -fgcse, and even 3 with -Os.  I doubt this will have any
> measurable impact, but one has to start somewhere.
> 
> Patch is untested beyond "it compiles", but that's really sufficient
> in this case anyway :-)
> 
> 	* gcse.c (CUID_INSN): Remove.
> 	(cuid_insn): Ditto.
> 	(alloc_gcse_mem): Don't allocate cuid_insn.
> 	(free_gcse_mem): Don't free cuid_insn.

I'd say just commit it as obvious, the last and only user of that has been
removed more than 3 years ago, incidentally by you:

2004-05-14  Steven Bosscher  <stevenb@suse.de>

        * passes.c (rest_of_handle_null_pointer): Remove.
        (rest_of_handle_cse): Don't call rest_of_handle_null_pointer.
        (rest_of_compilation): Likewise.
        * rtl.h (delete_null_pointer_checks): Remove prototype.
        * gcse.c (rd_kill, rd_gen, reaching_defs, rd_out, ae_in, ae_out):
        Remove declarations.
        (get_bitmap_width, alloc_rd_mem, free_rd_mem, handle_rd_kill_set,
        compute_kill_rd, compute_rd, alloc_avail_expr_mem,
        free_avail_expr_mem, compute_ae_gen, expr_killed_p, compute_ae_kill,
        expr_reaches_here_p, computing_insn, def_reaches_here_p,
        can_disregard_other_sets, handle_avail_expr, classic_gcse,
        one_classic_gcse_pass, invalidate_nonnull_info,
        delete_null_pointer_checks_1, delete_null_pointer_checks,
        expr_reached_here_p_work): Remove.
        (gcse_main): Do not perform classic GCSE when optimizing for size.
        (alloc_pre_mem, free_pre_mem): Don't touch ae_in and ae_out, they
        are never used.

	Jakub