Re: [PATCH][ix86/gcc-4_2-branch] committed, Initial Barcelona patches

["H.J. Lu" <hjl at lucon dot org>]

On Fri, Nov 09, 2007 at 05:03:17PM -0500, Michael Meissner wrote:
> I backported the initial Barcelona changes to the ix86/gcc-4_2-branch:
> 
> + /* Code generation for scalar reg-reg moves of single and double precision data:
> +      if (x86_sse_partial_reg_dependency == true | x86_sse_split_regs == true)
> +        movaps reg, reg
> +      else
> +        movss reg, reg
> +      if (x86_sse_partial_reg_dependency == true)
> +        movapd reg, reg
> +      else
> +        movsd reg, reg
> + 
> +    Code generation for scalar loads of double precision data:
> +      if (x86_sse_split_regs == true)
> +        movlpd mem, reg      (gas syntax)
> +      else
> +        movsd mem, reg
> +  
> +    Code generation for unaligned packed loads of single precision data
> +    (x86_sse_unaligned_move_optimal overrides x86_sse_partial_reg_dependency):
> +      if (x86_sse_unaligned_move_optimal)
> +        movups mem, reg
> + 
> +      if (x86_sse_partial_reg_dependency == true)
> +        {
> +          xorps  reg, reg
> +          movlps mem, reg
> +          movhps mem+8, reg
> +        }
> +      else
> +        {
> +          movlps mem, reg
> +          movhps mem+8, reg
> +        }
> + 
> +    Code generation for unaligned packed loads of double precision data
> +    (x86_sse_unaligned_move_optimal overrides x86_sse_split_regs):
> +      if (x86_sse_unaligned_move_optimal)
> +        movupd mem, reg
> + 
> +      if (x86_sse_split_regs == true)
> +        {
> +          movlpd mem, reg
> +          movhpd mem+8, reg
> +        }
> +      else
> +        {
> +          movsd  mem, reg
> +          movhpd mem+8, reg
> +        } */

Hi Michael,

I think those comments are misplaced. The same problem is also
in mainline. Can you take a look at it?

Thanks.


H.J.