This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix tree-data-ref.c ICE on VIEW_CONVERT_EXPR<type>(0) (PR tree-optimization/33856)
On 10/27/07, Andrew Pinski <pinskia@gmail.com> wrote:
> On 10/27/07, Jakub Jelinek <jakub@redhat.com> wrote:
> > and whole key var is uninitialized, but assigned.
>
> This was introduced by:
> 2007-10-01 Alexandre Oliva <aoliva@redhat.com>
>
> PR middle-end/22156
>
> I don't see a reason for using 0 for unitialized variables and if we
> are going to use that for structs, then an empty CONSTRUCTOR should be
> used instead.
I agree. I also see lots of comparisons like TYPE_MAIN_VARIANT () !=
TYpE_MAIN_VARIANT, instead most of the cases should use
!types_compatible_p () or !useless_type_conversion_p in case you know
what
is assigned to what.
Richard.