This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC, patch] An attempt to fix PR tree-optimization/33833 ICE in build2_stat, at tree.c:3110


Hi,

> The problem is I don't know if the conversion of data-ref's init or offset
> to unsigned type is correct. AFAIU, both init and offset can be negative
> (and this is the reason why they are ssizetype).

this conversion does not affect the result of the addition, and
POINTER_PLUS_EXPR requires the offset to have sizetype, so

> Index: ChangeLog
> ===================================================================
> --- ChangeLog   (revision 129623)
> +++ ChangeLog   (working copy)
> @@ -1,5 +1,11 @@
>  2007-10-25  Ira Rosen  <irar@il.ibm.com>
> 
> +       PR tree-optimization/33833
> +       * tree-vect-analyze.c (vect_analyze_data_refs): Use POINTER_PLUS_EXPR
> +       and convert init to sizetype in inner_base construction.
> +

the patch is OK.

Zdenek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]