This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR33168, ppc64 bootstrap failure
- From: Richard Sandiford <rsandifo at nildram dot co dot uk>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, segher at kernel dot crashing dot org
- Date: Mon, 22 Oct 2007 22:05:11 +0100
- Subject: Re: [PATCH] Fix PR33168, ppc64 bootstrap failure
- References: <Pine.LNX.4.64.0710221752110.4086@zhemvz.fhfr.qr>
Richard Guenther <rguenther@suse.de> writes:
> This patch from Segher fixes the bootstrap failure on ppc64.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, i686-pc-linux-gnu,
> ia64-unknown-linux-gnu and ppc-unknown-linux-gnu, built on
> ppc64-unknown-linux-gnu.
>
> Ok for mainline? Segher, would you please add a ChangeLog entry? ;)
>
> (I added parantheses around the XOR compared to the original patch)
I think this patch is papering over the real bug. It isn't legitimate
to mix read-write and read-only section statements. E.g.:
.section .foo,"a",@progbits
.section .foo,"aw",@progbits
produces an unconditional warning:
Warning: ignoring changed section attributes for .foo
so it seems dangerous for gcc to allow it, especially in cases where the
user hasn't even used section attributes.
It sounds like the real bug is what Alan describes in comment #11,
namely that the front end is changing something's visiblity after
having created RTL for it.
Richard