This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] m68k: Fix uses of curly braces in the assembly output


Hi Andrew,

This patch fixes the problem by using "%{" and "%}" and adding support
for that in print_operand and PRINT_OPERAND_PUNCT_VALID_P.


Couldn't/shouldn't %{/%} be handled in the generic code?

I just did a quick search for %{ and %}. Neither of them seems to occur in assembly output. I'll submit a patch to support %{ and %} in target-independent code.

I take it back. The MIPS port does something special with '%{' and '%}'. (See mips.c:print_operand.) I would still like to keep '%{' and '%}' specific to m68k port.


I could still move the handling of '%{' and '%}' to the target-independent code by enabling the code only when ASSEMBLER_DIALECT is defined. This way, the MIPS port wouldn't be affected, but I don't like the resulting complexity. Plus, I would be essentially restricting the MIPS port to use ASSEMBLER_DIALECT in future.

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]