This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Add -Wcast-qual to the bootstrap warning flags
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Sun, 23 Sep 2007 21:17:32 -0700
- Subject: Re: [PATCH]: Add -Wcast-qual to the bootstrap warning flags
- References: <Pine.GSO.4.58.0709232333370.7689@caipclassic.rutgers.edu>
On 9/23/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> + asprintf (CONST_CAST(char **, &m68k_library_id_string),
^
Missing space. Also this looks wrong anyways.
> + cselib_val *e = cselib_lookup (CONST_CAST_RTX(x), GET_MODE (x), 0);
Likewise.
> + cselib_val *e = cselib_lookup (CONST_CAST_RTX(y), GET_MODE (y), 0);
And again.
Can you double check all of the added CONST_CAST* to make sure they
have the needed space between the macro name and the parentheses?
Also why can't cselib_lookup take const_rtx? I think you need to take
more time to think about all of these const_* changes before just
adding CONST_CAST*.
Thanks,
Andrew Pinski