This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] reorganize simplify_const_relational_operation

On 18 September 2007 21:17, Eric Botcazou wrote:

>> Okay, so I'll s/enum cr_flags/int/ (except in the definition of course).
> 
> Thanks.  Btw, what do you think about the extension code just above?

> 	  l0u &= ((HOST_WIDE_INT) 1 << width) - 1;
> 	  l1u &= ((HOST_WIDE_INT) 1 << width) - 1;
> 
> 	  if (l0s & ((HOST_WIDE_INT) 1 << (width - 1)))
> 	    l0s |= ((HOST_WIDE_INT) (-1) << width);
> 
> 	  if (l1s & ((HOST_WIDE_INT) 1 << (width - 1)))
> 	    l1s |= ((HOST_WIDE_INT) (-1) << width);

  I think that's a really awful choice of variable names in a monospaced font!
:-)


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]