This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Improve debuggability at -O0 and fix PR 29609


Hi Richard (and sorry for the delay),

So I ask you to improve this case first, set the correct location separately
on the condition and the jump. Like you did for expand_gimple_basic_block
(do you have a testcase for this fix? that looks like an issue that can be
fixed separately from the others).

here is a patch that do what you suggested.
expand_gimple_cond_expr is modified to insert jump forwarder with correct location.


There is additional conditions in cfgcleanup to avoid removing this added forwarder and some
code in cfgrtl to be sure the locator is set before generated jump_insn.


This is just to be sure I correctly understood your suggestion. I have not run the testsuite on the final
version of this patch. I have not yet checked if unexpected jumps were added. The code generated for the
test case is ok.


Tristan.

Attachment: goto2.diff
Description: Binary data




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]