This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR29396 PR29606 PR30625 and PR30871 - subreference array pointers.
- From: Thomas Koenig <tkoenig at alice-dsl dot net>
- To: Paul Thomas <paulthomas2 at wanadoo dot fr>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 15 Sep 2007 21:31:07 +0200
- Subject: Re: [Patch, fortran] PR29396 PR29606 PR30625 and PR30871 - subreference array pointers.
- References: <46E43421.4010605@wanadoo.fr> <46EBEB96.3070807@wanadoo.fr>
On Sat, 2007-09-15 at 16:26 +0200, Paul Thomas wrote:
> > It is my opinion that this patch is ready for 4.3 simply because it
> > provides an extra functionality that is ringfenced by specific tests.
> > Such pointer assignements, at present, either lead to ICEs or wrong
> > code. Hence, even if it is not in its final form, it will not break
> > anything, whilst filling in the missing f95 feature.
> >
>
> I think that this is more true than ever, since it is now more or less
> fully functioning.
I concur that this appropriate for stage 3, as this fixes PR 30625,
a particularly nasty wrong-code bug where we accept correct code and
generate wrong results.
> Bootstrapped and regtested on x86_ia64/FC5 - OK for trunk?
Re-regression tested on i686-pc-linux-gnu. This also passed all test
cases that I could think of, and the *.original code looks good.
OK for trunk.
Thanks a lot for fixing this!
Thomas