Re: Unbreak bootstrap

[Ian Lance Taylor <iant at google dot com>]

Jan Hubicka <jh@suse.cz> writes:

> > On 9/4/07, Jan Hubicka <jh@suse.cz> wrote:
> > > Hi,
> > > Richard's patch to remove volatile flag from loads broke tailcall code
> > > to update SSA form.  The following patch bootstrapped for me on
> > > x86_64-linux and I went ahead and comitted it as it is pretty obvious to
> > > unbreak testing...
> > 
> > Actually this patch does not make sense as what is failing is using
> > stage2's compiler so we must be miscompiling stage2 already.
> > Compiling stage2 is ok.  I might be better if we revert Richard's
> > patch until he figures out what is going wrong.
> 
> Actually I think I know what is going wrong - the tailcall is checking
> for zero virtual operands to verify that it is safe to do the
> conversion.  Without alias info represented the statements might
> actually read from memory that is affected by the conversion.
> 
> I agree that reverting both patches is way to go for now.

I'll approve reverting both patches until Richard can figure out what
went wrong.

Your original message didn't say where bootstrap failed--Richard will
presumably need that to recreate the problem.

Thanks.

Ian