This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH][C] Fix GNU extern inline heuristic again (fix C++ memory usage regression)


On 27 August 2007 19:15, Ian Lance Taylor wrote:

> Richard Guenther <rguenther@suse.de> writes:
> 
>> +   /* For GNU C extern inline functions disregard inline limits.  */
>> +   if (DECL_EXTERNAL (fndecl)
>> +       && DECL_DECLARED_INLINE_P (fndecl))
>> +     DECL_DISREGARD_INLINE_LIMITS (fndecl) = 1;
> 
> You may have found a bug here.  I see that you are just replicating
> the existing code.  But a GNU C extern inline function is not the same
> as a C99 extern inline function.  I don't see any obvious reason why
> we should disregard inline limits for a C99 extern inline function.

  Did you see http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01832.html ?



    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]