This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: fine-tuning for can_store_by_pieces


Mark Mitchell wrote:

In the various places where you clone the macro, I think you should just
 do:

#define SET_BY_PIECES_P(SIZE, ALIGN) STORE_BY_PIECES_P(SIZE, ALIGN)

In fact, if you do that in expr.c, under #ifndef SET_BY_PIECES_P, I
think you can void changing the other backends at all, as you'll
automatically pick up their STORE_BY_PIECES_P definitions.

I previously considered that idea, but that means that just defining SET_RATIO to be different than MOVE_RATIO won't do anything useful. Making the default definition of SET_BY_PIECES_P use SET_RATIO and making the latter default to MOVE_RATIO seemed to be the best combination of avoiding breaking current backend code while making it easy to tweak in the future. If I do it your way, there's no point in having SET_RATIO in the target-independent code at all, because nothing would refer to it.


-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]