This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] Use correct type for transferring array descriptor info to library
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Jul 2007 07:28:05 +0100
- Subject: Re: [Patch, fortran] Use correct type for transferring array descriptor info to library
- References: <46A8ACDC.8090608@gmail.com>
I plan to commit the following obvious patch in 24 hours unless
someone objects. The problem is that the array descriptor triplets
for each dimension (ubound, stride, lbound) are transferred as
GFC_INTEGER_4 rather than as the correct array index type
(typedeffed to ssize_t). It's a rather obscure bug, surfacing only
when doing namelist I/O on big arrays on 64-bit platforms. But it's
the right thing to do, so it should be done.
Do you have any ways to write a testcase that doesn't need gigabytes
of disk space?
The patch is otherwise OK.
FX