This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch: mingw/cygwin] Don't strip '@' dangles from stdcall/fastcall dllimport references
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: Danny Smith <dannysmith at clear dot net dot nz>
- Cc: "'Dave Korn'" <dave dot korn at artimi dot com>, "'GCC-patches'" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 16 Jul 2007 08:52:17 +0200
- Subject: RE: [Patch: mingw/cygwin] Don't strip '@' dangles from stdcall/fastcall dllimport references
Hi Danny,
> I'm sorry. I don't know what you mean. AFAICT
> default_strip_name_encoding should work on 64 bit as well as 32 bit
> Windows targets. Where would you simplify the reading with an
'if-clause'?
Sorry that I was a bit unclear. I agree, that the method
i386_pe_strip_name_encoding_full works for 64bit windows, too. But this
method is a target export by the macro TARGET_STRIP_NAME_ENCODING,
defaulted in the header "target-def.h". Therefore I want to suggest to
insert into i386_pe_strip_name_encoding_full method the following pattern:
+ /* 64bit does not need any stripping, because fastcall and stdcall
+ do not append '@' for this target. */
+ if (TARGET_64BIT)
+ return default_strip_name_encoding (name);
This I think, clarifies the usage of this macro. AFAICS is this macro
nowhere used in the backend, but it could be.
Cheers,
i.A. Kai Tietz
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
------------------------------------------------------------------------------------------
OneVision Software Entwicklungs GmbH & Co. KG
Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
Handelsregister: HRA 6744, Amtsgericht Regensburg
KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer:
Ulrike DÃhler, Manuela Kluger