This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][RFC] Another approach to fixing "bad" inlining


On Wed, 11 Jul 2007, Alexandre Oliva wrote:

> On Jul 10, 2007, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> 
> > We ran into the same problem a few years ago with C functions casted to 
> > incompatible function types.  Inlining in this case led to ICEs in the RTL 
> > expander.  We "solved" the problem by generating an explicit trap in lieu
> > of the bogus function call:
> 
> FWIW, issuing a warning and replacing the function call with a trap
> sounds like a better choice than leaving the argument uninitialized to
> me.

We can't do that at this point.  What we can do is use a 
VIEW_CONVERT_EXPR to convert the something that get's passed into
something that is expected.  But I suppose in cornercases this
is more fragile than leaving the argument uninitialized.

Not to say, in an ideal world I would expect the C frontend to
fix this up (like it does for the incompatible function types case
that is solved with the builtin_trap).

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]