Re: PATCH: add DOLLARS_IN_ASM_IDENTIFIERS

["Andrew Pinski" <pinskia at gmail dot com>]

On 7/6/07, Sandra Loosemore <sandra@codesourcery.com> wrote:
> > This is OK if it passes bootstrap.
>
> Yup, committed now.  Thanks.

Which target did you test on?  Because you did not mention it.
Anyways this causes PR 32670 (a bootstrap failure on i686-linux-gnu in libffi )
aka http://gcc.gnu.org/ml/gcc/2007-07/msg00233.html :


> My i686-pc-linux-gnu build fails with
>
> libtool: link: /exp/ldroot/dodes/i686-gcc-orig/gcc/gcj -B/exp/ldroot/dodes/i686-gcc-orig/i686-pc-linux-gnu/libjava/ -B/exp/ldroot/dodes/i686-gcc-orig/gcc/ -ffloat-store -fomit-frame-pointer -Usun -g -O2 -o .libs/jv-convert --main=gnu.gcj.convert.Convert -shared-libgcc  -L/exp/ldroot/dodes/i686-gcc-orig/i686-pc-linux-gnu/libjava/.libs -L/exp/ldroot/dodes/i686-gcc-orig/i686-pc-linux-gnu/libjava ./.libs/libgcj.so -lpthread -lrt -ldl -Wl,-rpath -Wl,/usr/local/lib
> ./.libs/libgcj.so: undefined reference to `FFI_TYPE_DOUBLE'
> ./.libs/libgcj.so: undefined reference to `FFI_TYPE_SINT64'
> ./.libs/libgcj.so: undefined reference to `FFI_TYPE_LONGDOUBLE'
> ./.libs/libgcj.so: undefined reference to `FFI_TYPE_INT'
> ./.libs/libgcj.so: undefined reference to `FFI_TYPE_FLOAT'
> ...
>
> on revision 126435.  Anyone else sees this failure?
>
> It looks cc1 -E -lang-asm outputs cmpl $FOO,%ecx instead
> of cmpl $3,%ecx for
>
> #define FOO 3
> cmpl  $FOO,%ecx

-- Pinski