This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed Tru64 UNIX patches


Rainer Orth <ro@techfak.uni-bielefeld.de> writes:

> Ian Lance Taylor writes:
> 
> > > My preference would be not to modify gthr-posix.h, but instead
> > > add #pragma weak pthread_... to gthr-posix.c for all symbols that
> > > file defines.
> > 
> > Why not use __attribute__ ((weak))?
> 
> As I mentioned to Jakub, I went the _Pragma route because it avoided to
> have the functions defined/declared in three places.  __attribute__
> ((weak)) should work as well.
> 
> Unfortunately, I had already checked in my patch in all three branches
> based on Diegos approval before your mail arrived.  Do you want me to go
> the __attribute__ ((weak)) road instead?

Oh, I missed his approval.  Don't worry about, then.  Unless it seems
desirable to have these functions be weak on platforms other than
Tru64.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]