This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][c++/PR 31743]


Mark Mitchell wrote:
This comment isn't quite accurate:

+ /* PR 31743: Make sure the array type has a known size. */
+ if (!complete_type_or_else (type, NULL_TREE))
+ return error_mark_node;

because this check isn't just about array types. Better would be:


/* The type allocated must be complete.  If the new-type-id was "T[N]"
   then we are just checking that "T" is complete here, but that is
   equivalent, since the value of "N" doesn't matter.  */

(I'm not a fan of putting PR numbers in comments; the comment ought to
stand on itself.)

OK with that change; no need to retest.
OK. Can you please commit the patch with this change? I don't think I have write access.

Thanks!
Dave


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]