This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: Fix PR 32571

From: "Daniel Berlin" <dberlin at dberlin dot org>
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 2 Jul 2007 09:59:30 -0400
Subject: Re: [PATCH]: Fix PR 32571
References: <4aca3dc20707012034r47427d35u8a8b6d294bd34be9@mail.gmail.com> <84fc9c000707020100g643b6dc6u558d7b2ff75fde1f@mail.gmail.com>

Done

On 7/2/07, Richard Guenther <richard.guenther@gmail.com> wrote:

On 7/2/07, Daniel Berlin <dberlin@dberlin.org> wrote:
> Before this patch, SCCVN would try to simplify copies, and sometimes
> come up with a more complex expression the copy represented.  Because
> of how SCCVN works, this is pointless and detrimental, and on 32571,
> tripped an assert put there to make sure we didn't end up with chains
> of copies.
>
> Fixed by checking for obvious copies before simplifying.
>
> Bootstrapped and regtested on i686-darwin.  Committed.

Can you add the testcase from the PR as well?

Thanks,
Richard.

> 2007-07-01  Daniel Berlin  <dberlin@dberlin.org>
>
>         Fix PR tree-optimization/32571
>         * tree-ssa-sccvn.c (visit_use): Shortcut copies to avoid
>         simplifying them.
>
>

References:
- [PATCH]: Fix PR 32571
  - From: Daniel Berlin
- Re: [PATCH]: Fix PR 32571
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]