This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH for note_stores
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Rask Ingemann Lambertsen <rask at sygehus dot dk>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 11 Jun 2007 16:31:20 -0700
- Subject: Re: PATCH for note_stores
- References: <20070608192902.GP5690@sygehus.dk>
Rask Ingemann Lambertsen wrote:
>> Index: rtlanal.c
>> ===================================================================
>> RCS file: /cvs/gcc/egcs/gcc/rtlanal.c,v
>> retrieving revision 1.43
>> diff -c -p -r1.43 rtlanal.c
>> *** rtlanal.c 1999/10/20 14:04:01 1.43
>> --- rtlanal.c 1999/10/27 18:56:57
>
> The comment above note_stores() should be updated to mention the new
> parameter.
True, though 8 years seems like it ought to be beyond the statue of
limitations on coding standards violations. :-)
I checked in the following patch.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
2007-06-11 Mark Mitchell <mark@codesourcery.com>
* rtlanal.c (note_stores): Improve documentation.
Index: rtlanal.c
===================================================================
--- rtlanal.c (revision 125605)
+++ rtlanal.c (working copy)
@@ -1394,10 +1394,13 @@ reg_overlap_mentioned_p (rtx x, rtx in)
}
/* Call FUN on each register or MEM that is stored into or clobbered by X.
- (X would be the pattern of an insn).
- FUN receives two arguments:
- the REG, MEM, CC0 or PC being stored in or clobbered,
- the SET or CLOBBER rtx that does the store.
+ (X would be the pattern of an insn). DATA is an arbitrary pointer,
+ ignored by note_stores, but passed to FUN.
+
+ FUN receives three arguments:
+ 1. the REG, MEM, CC0 or PC being stored in or clobbered,
+ 2. the SET or CLOBBER rtx that does the store,
+ 3. the pointer DATA provided to note_stores.
If the item being stored in or clobbered is a SUBREG of a hard register,
the SUBREG will be passed. */