Re: [patch, fortran] PR29651 (wrong code), PR30933 (undefined reference)

["Daniel Franke" <franke dot daniel at gmail dot com>]

2007/6/2, FX Coudert <fxcoudert@gmail.com>:
> :REVIEWMAIL:
>
> > 2007-05-31  Daniel Franke  <franke.daniel@gmail.com>
> >
> > 	PR fortran/29651
> > 	PR fortran/30933
> > 	* iresolve.c (gfc_resolve_exit, gfc_resolve_signal_sub): Removed.
> > 	* intrinsic.c (add_subroutines): Removed resolver-functions
> > 	from EXIT and SIGNAL.
> > 	* trans.h (gfc_conv_intrinsic_subroutine):  New prototype.
> > 	* trans-decl.c (gfor_fndecl_exit_sub, gfor_fndecl_signal_sub,
> > 	gfor_fndecl_signal_sub_int): New subroutine declarations.
> > 	(gfc_build_intrinsic_function_decls): Added subroutine declarations.
> > 	* trans-stmt.c (gfc_trans_call): Translate intrinsic subroutines
> > via ...
> > 	* trans-intrinsic.c (gfc_conv_intrinsic_subroutine): ... this new
> > function.
> > 	(gfc_conv_intrinsic_exit_sub): New.
> > 	(gfc_conv_intrinsic_signal_sub): New.
>
> OK for me. As it represents a significantly new way of handling the
> subroutines, please wait another 48h for other maintainers to step in
> and comment.

FX,

thanks for your review. Before committing, I found some cases were
this patch would introduce new wrong-code bugs, thus I have to do some
additional work. There won't be much time to devote to it within the
next two weeks but when done I'll resubmit a revised patch.

Regards
   Daniel