This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, libgfortran] Remove small_buffer, unneccessary buffer for internal I/O


On 5/24/07, Jerry DeLisle <jvdelisle@verizon.net> wrote:
This patch looks good.  For the common stuff, One could try to create a separate
structure for all the common items above and create two new structures.

typedef struct
{
   comstream s;
   char buffer[BUFFER_SIZE];
} unix_tream;

typedef struct
{
   comstream s;
   char * intbuf;
} intstream;

Yes, that would be the obvious and neat solution.


That may require a lot of editing.

.. and this is the reason why I didn't want to do it. :)


The patch as it is now works well.

Thanks for the review. Committed to trunk.



-- Janne Blomqvist


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]