Re: [PATCH, testsuite] Fix PASS->UNSUPPORTED on g++.dg/tls/static-1.C

[Adam Nemet <anemet at caviumnetworks dot com>]

Janis Johnson writes:
> It would also be possible to add another documented restriction to the
> use of dg-require-effective-target, that it must appear before
> dg-additional-sources.  There are lots of strange interactions between
> test directives and I'd rather document them (and hope that some of us
> remember to look them up in the Test Directives part of the internals
> manual) instead of adding more workarounds.

I thought about this too and I agree in general but the decision
should be made based on the semantics of the directives.

In this particular case there is really no semantical reason why
dg-additional-source and dg-require-effective-target should effect
each other.  It is unambiguous that the test case declared
dg-additional-source to be used when building the testcase and never
the feature test so the framework should be friendly enough to work
with this.

I also think that in general the dg languages is not sensitive to
ordering which is why for example there are keywords like dg-final.

Adam