This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add SSE4.1 testcases


On May 22, 2007, at 7:23 AM, Uros Bizjak wrote:
On 5/22/07, H. J. Lu <hjl@lucon.org> wrote:

> This is all code that needs to be duplicated...

I wrote those SSE3/SSSE3 tests. Looking back, I wish I had done the
way I did for SSE4.1 tests.

I have no strong preference for either approach, so it is your call.

My take... I prefer check_effective_target_sse4 as well. All the magic is put in one place, and reused in many. Conversion to any other scheme is trivial in the testcases, simple to read and understand, easier to get right. We reduce the pressure on people to do cut-n-paste programming, which is bad.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]