This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR target/31628: stdcall function is miscompiled


On Fri, May 18, 2007 at 12:16:58PM -0700, Janis Johnson wrote:
> On Fri, May 18, 2007 at 08:57:48AM -0700, H. J. Lu wrote:
> > --- gcc/testsuite/gcc.target/i386/pr31628.c.foo	2007-05-18 08:52:06.000000000 -0700
> > +++ gcc/testsuite/gcc.target/i386/pr31628.c	2007-05-18 08:50:26.000000000 -0700
> > @@ -0,0 +1,24 @@
> > +/* { dg-do run } */
> > +/* { dg-require-effective-target ilp32 } */
> > +/* { dg-options "-m32 -fPIC -O2" } */
> 
> Don't use -m32 in a test.  In this case it's particularly redundant
> because the previous directive is already skipping the test if the
> current effective target isn't ilp32.

I checked it in without -m32.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]