This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add __GCC_HAVE_SYNC_COMPARE_AND_SWAP_*

On 5/18/07, Paolo Carlini <pcarlini@suse.de> wrote:

Agreed about everything, thanks for your help. I think the attached
(tested x86_64-linux multilib, and x86-linux) implements all your
suggestions.

Ok for mainline now?

I would add also

+#ifdef __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16

to ..._swap-1.c,

+#ifdef __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8
+#ifdef __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16

to ..._swap-2.c and

+#ifdef __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16

to ..._swap-3.c

just to cover all cases... Anyway, the i386 part (tests) are OK, and
althoug I can't approve cpp part it looks pretty safe to me, having
all these #ifdefs around.

Thanks,
Uros.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]