This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR29397 and PR29400 - parameter arrays with scalar initializers


FX,

and go down to the last element to add the new one. I'd suggest to
change the code to something like the following:

If you look at the PR, I did pretty much that in the first place and decided to use the array.c API at the last minute. You are quite right - I'll revert to the old version.

So, my question is: why can't we use the repeat element of the
constructor structure for that? (I tried, but it appears to be
ignored later, as if the array had only one element; the comment on
top of the structure definition in gfortran.h hints that it's only
used for data initialization).

I tried it and discovered the same. It gets simplified away, I think. I'll stick in a TODO.

To summarize: the patch is OK, with the modification I suggest above
or something similar.

I'll make it so.

Thanks

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]