This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: More empty body checks

From: Mark Mitchell <mark at codesourcery dot com>
To: Mike Stump <mrs at apple dot com>
Cc: gcc-patches at gcc dot gnu dot org, Gabriel Dos Reis <gdr at cs dot tamu dot edu>
Date: Mon, 07 May 2007 16:25:41 -0700
Subject: Re: More empty body checks
References: <20070426010908.9B41C1C67DF@mrs2.apple.com> <463E6420.7000408@codesourcery.com> <0DE5A958-E9ED-40BA-9CA4-88DEA8D2FB9B@apple.com>

Mike Stump wrote:

>> This should be folded into the callers, to avoid the redundant token
>> peeking:
>>
>>   if (cp_parser_require (CPP_CLOSE_PAREN))
>>     check_empty_body (...);
> 
> Ah, but they already do this.  The problem is that I need to hold onto
> the token or the location information at least after that point, so, I
> need to run before it's required, as otherwise it would be consumed. 

The peeking is pretty cheap, so let's not worry about it.

Revised version is OK.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- Re: More empty body checks
  - From: Mark Mitchell
- Re: More empty body checks
  - From: Mike Stump

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]