This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix fallout of CFG scanning patch
- From: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
- To: Diego Novillo <dnovillo at acm dot org>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 7 May 2007 15:34:10 +0200
- Subject: Re: [PATCH] Fix fallout of CFG scanning patch
- References: <463F0847.70407@acm.org>
Hello,
> Eric Botcazou wrote on 05/06/07 15:44:
>
> > 2007-05-06 Eric Botcazou <ebotcazou@adacore.com>
> >
> > * tree-ssa-dom.c (tree_ssa_dominator_optimize): Reset cfg_altered.
> > Free dominance info before purging EH edges as well as after.
> > (eliminate_degenerate_phis): Likewise.
> > (propagate_rhs_into_lhs): Set cfg_altered to true instead of 1.
>
> OK.
actually, it should not be necessary to call free_dominance_info if
tree_purge_all_dead_eh_edges changes something. As a result of the
patch, tree_purge_all_dead_eh_edges correctly updates the dominance
information (of course, assuming that the dominance information is
correct before it is called).
I.e., the parts of the patch that move free_dominance_info before
tree_purge_all_dead_eh_edges are OK, adding the new free_dominance_info
calls after tree_purge_all_dead_eh_edges is not necessary.
Zdenek