This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Document --help=<language>


Nick Clifton wrote:
  I would like permission to apply the attached patch which resolves
  PR 31355.  It adds documentation of the fact that the --help= option
  can accept a language name as a parameter and it fixes the
  --help=<language> output so that the language name is always
  displayed.

Again, I'd already posted patches to fix this, but the patch tracker didn't notice to put them in the PRs:
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01655.html
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01657.html


One difference that I see between our patches -- you have:
+ if (* descrip_extra == '\0')
+ descrip_extra = lang_names [i];
whereas mine just unconditionally assigns descrip_extra to lang_names[i]. Is there are reason you made this conditional?


- Brooks



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]