This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix integer/pointer size mismatch in splay-tree.h
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: bje at au1 dot ibm dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 13 Mar 2007 10:08:02 +0100
- Subject: Re: PATCH: Fix integer/pointer size mismatch in splay-tree.h
DJ Delorie <dj@redhat.com>
12.03.2007 19:40
To
Kai.Tietz@onevision.com
cc
gcc-patches@gcc.gnu.org, bje@au1.ibm.com
Subject
Re: PATCH: Fix integer/pointer size mismatch in splay-tree.h
>> As to see, this patch is obvious. Sorry, that I posted it first to
>> the wrong news group.
>Patches which change a public API are *never* obvious. This one in
>particular is incorrect on m32c, for example, where size_t is smaller
>than long.
Ok, not obvious, but obviously wrong for targets with type long less than
a pointer size. By the reason that GTY is used for this type, an #if -
clause won't help.
What's to do in your opinion ? May introducing eg. in ansidecl.h (but of
course it is not really an ansi issue) a type with the size
max(sizeof(long),sizeof(void*)) ?