This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Force DFP function args into FP registers per the ABI
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Janis Johnson <janis187 at us dot ibm dot com>, Ben Elliston <bje at au1 dot ibm dot com>
- Date: Fri, 02 Mar 2007 08:52:41 -0500
- Subject: Re: [PATCH] Force DFP function args into FP registers per the ABI
- References: <20070223192343.GA18123@vervain.rchland.ibm.com>
The patch generally looks okay. Too bad these new modes need to
diffuse into everything.
+ /* Must use an even/odd register pair. */
Would you please clarify this with "Decimal Float must..." or "_Decimal128
must..." in both places?
+ case DDmode:
case DFmode:
case SFmode:
if (CONSTANT_P (operands[1])
Please list DDmode after DFmode, so the ordering is consistent
everywhere. When browsing these functions for modes, it's confusing to
have the decimal modes jump around.
+;; Copyright (C) 2006
The file is being added to the FSF in 2007, so the copyright should list
2007.
Okay with those changes.
Thanks, David