This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [CRIS PATCH] Use predicates instead of GET_CODE ()
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: jbglaw at lug-owl dot de
- Cc: gcc-patches at gcc dot gnu dot org, hans-peter dot nilsson at axis dot com
- Date: Sun, 18 Feb 2007 23:40:45 +0100
- Subject: Re: [CRIS PATCH] Use predicates instead of GET_CODE ()
> Date: Sun, 18 Feb 2007 22:13:19 +0100
> From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
> During some spare time, I started to work on moving some code over to
> use the predicate macros instead of explicit GET_CODE() calls.
Thank you for your work. I probably sound ungrateful, but I
don't think it's always a great idea to convert existing
*target* files like this, as it adds to the noise the target
maintainer has to deal with when backporting bugfixes across
different versions in different repositories (both in FSF and
local). But since you took the time...
> This is /not/ yet regtested! It would be nice if Hans-Peter could to
> do that for me...
I'd like to take the opportunity to point out that if it hadn't
been for cris-sim.exp not being in dejagnu-1.4.4, anyone could
do this regtest; see simtest-howto.html.
The file cris-sim.exp can be downloaded at
<URL:http://cvs.savannah.gnu.org/viewcvs/*checkout*/dejagnu/dejagnu/baseboards/cris-sim.exp>.
Then just add cris-sim.exp to your local baseboard files.
If you don't have any "local baseboard files", start your
collection by e.g. creating the directory "~/dejagnuboards" and
put "cris-sim.exp" there. Then add the line
"set boards_dir ~/dejagnuboards" in the (possibly new) file "~/.dejagnurc"
(remove all quotes ;)
> * config/cris/cris.c (cris_movem_load_rest_p, cris_store_multiple_op_p,
> cris_print_index, cris_print_operand, cris_print_operand_address,
> cris_reload_address_legitimized, cris_rtx_costs, cris_address_cost,
> cris_side_effect_mode_ok, cris_valid_pic_const, cris_split_movdx,
> cris_expand_pic_call_address): Use xxx_P predicate macros instead of
> GET_CODE () == xxx.
> * config/cris/cris.h (SECONDARY_RELOAD_CLASS, EXTRA_CONSTRAINT_Q,
> EXTRA_CONSTRAINT_T, BDAP_INDEX_P, BIAP_INDEX_P, SIMPLE_ADDRESS_P,
> GO_IF_LEGITIMATE_ADDRESS): Dito.
It's "ditto" in English.
Thanks, it looks otherwise fine, I'll test and commit.
:REVIEWPATCH:
brgds, H-P