Re: PING: [PATCH] Add a new option -Wvariable-length-array

["Seongbae Park" <seongbae dot park at gmail dot com>]

On 2/14/07, Seongbae Park <seongbae.park@gmail.com> wrote:
> Please review:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-02/msg00868.html
>
> Thanks!

Fixed everything Manuel pointed out (many thanks!).
The updated patch is attached.
Following is the ChangeLog diff:

Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog       (revision 121965)
+++ gcc/ChangeLog       (working copy)
@@ -1,3 +1,10 @@
+2007-02-14  Seongbae Park <seongbae.park@gmail.com>
+       * c-decl.c (warn_variable_length_array): New function.
+       Refactored from grokdeclarator to handle warn_vla
+       and handle unnamed array case.
+       (grokdeclarator): Refactored VLA warning case.
+       * c.opt (Wvla): New flag.
+
2007-02-14  Richard Henderson  <rth@redhat.com>

       * tree-sra.c (early_sra): New.
@@ -25,7 +32,7 @@
       * builtin-types.def (DEF_FUNCTION_TYPE_x): Do not imply that at
       most 3 arguments are supported.
       (DEF_FUNCTION_TYPE_VAR_5): Fix typo in its description.
-
+
2007-02-13  Seongbae Park <seongbae.park@gmail.com>

       * bitmap.c (bitmap_and, bitmap_and_compl, bitmap_xor):

Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog     (revision 121965)
+++ gcc/testsuite/ChangeLog     (working copy)
@@ -1,3 +1,16 @@
+2007-02-14  Seongbae Park <seongbae.park@gmail.com>
+
+       * gcc.dg/wvla-1.c: New test
+       * gcc.dg/wvla-2.c: New test
+       * gcc.dg/wvla-3.c: New test
+       * gcc.dg/wvla-4.c: New test
+       * gcc.dg/wvla-5.c: New test
+       * gcc.dg/wvla-6.c: New test
+       * gcc.dg/wvla-7.c: New test
+       * g++.dg/warn/Wvla-1.C: New test
+       * g++.dg/warn/Wvla-2.C: New test
+       * g++.dg/warn/Wvla-3.C: New test
+
2007-02-14  Brooks Moses  <brooks.moses@codesourcery.com>

       * gfortran.dg/interface_10.f90: Fix comment typo.

Index: gcc/cp/ChangeLog
===================================================================
--- gcc/cp/ChangeLog    (revision 121965)
+++ gcc/cp/ChangeLog    (working copy)
@@ -1,3 +1,7 @@
+2007-02-14  Seongbae Park <seongbae.park@gmail.com>
+
+       * decl.c (compute_array_index_type): New warning flag warn_vla.
+
2007-02-13  Dirk Mueller  <dmueller@suse.de>

       * friend.c (do_friend): Annotate warning about friend

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 121965)
+++ ChangeLog   (working copy)
@@ -1,3 +1,7 @@
+2007-02-14  Seongbae Park <seongbae.park@gmail.com>
+
+       * gcc/doc/invoke.texi (Wvla): New warning.
+
2007-02-14  Gerald Pfeifer  <gerald@pfeifer.com>

       * ltconfig (freebsd*): Default to elf.

--
#pragma ident "Seongbae Park, compiler, http://seongbae.blogspot.com";

Attachment: wvla-4.diff.txt
Description: Text document