Re: [PATCH] [4.3 projects] vectorization of induction

[Diego Novillo <dnovillo at redhat dot com>]

Dorit Nuzman wrote on 01/01/07 11:14:

> 2006-12-31  Dorit Nuzman  <dorit@il.ibm.com>
>             Victor Kaplansky  <victork@il.ibm.com>
>
>         * tree-vectorizer.c (vect_is_simple_use): Support induction.
>         (vect_is_simple_reduction): Support reduction with induction as
>         one of the operands.
>         (vect_is_simple_iv_evolution): Fix formatting.
>         * tree-vect-analyze.c (vect_mark_stmts_to_be_vectorized): Fix
>         formatting.  Don't mark induction phis for vectorization.
>         (vect_analyze_scalar_cycles): Analyze all inductions, then
> reductions.
>         * tree-vect-transform.c (get_initial_def_for_induction): New
> function.
>         (vect_get_vec_def_for_operand): Support induction.
>         (vect_get_vec_def_for_stmt_copy): Fix formatting and add check for
>         induction case.
>         (vectorizable_reduction): Support reduction with induction as one
> of
>         the operands.
>         (vectorizable_type_demotion): Use def-type of stmt argument rather
>         than dummy def-type.
>
>         * tree-ssa-loop.c (gate_scev_const_prop): Return the value of
>         flag_tree_scev_cprop.
>         * common.opt (tree-scev-cprop): New flag.
>
>         * tree-vect-transform.c (vect_create_destination_var): Use 'kind'
> in
>         call to vect_get_new_vect_var.
I like these patches with more test cases than code.

OK with:


> !
> !   /* Check that one def is the reduction def, defined by 'phi',
s/'phi'/PHI/

> ! 
> !   /* Second - identify all reductions.  */
> !   for (phi = phi_nodes (bb); phi; phi = PHI_CHAIN (phi))
Why don't you just create a small task queue with the PHIs that you
found interesting in the first identification pass?  This would
simplify the logic in this other loop.