This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR30284 and PR30626 - ICEs with internal units


Paul Thomas wrote:
:ADDPATCH fortran:

These two PRs are effectively identical and are fixed by the same patch.

The problem is that substring or components references of arrays result in element sizes that are smaller than the stride in bytes. This is fixed by using the same temporary builder that fixed a similar problem in gfc_conv_function_call. A temporary is created that is copied to and used as the internal unit for READ or is used and copied back from for WRITE. The testcases are the reporter's.

Note that I am perfectly prepared to change the names of gfc_conv_aliased_arg and is_aliased_array, if only somebody would tell me what they should be called :-)

Bootrtrapped and regtested on amd64/Cygwin_NT - OK for trunk and a week or two later for 4.2?

Paul,

This is OK for trunk and 4.2 as stated. Note: I also tested on x86-64-Linux.

Thanks,

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]