This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ffi powerpc64 unwind info
- From: Andrew Haley <aph at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Alan Modra <amodra at bigpond dot net dot au>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Feb 2007 11:22:49 +0000
- Subject: Re: [PATCH] Fix ffi powerpc64 unwind info
- References: <20061124210934.GQ6570@devserv.devel.redhat.com> <17857.50042.591582.376205@zebedee.pink> <20070201111457.GE27294@devserv.devel.redhat.com>
Jakub Jelinek writes:
> On Thu, Feb 01, 2007 at 10:39:54AM +0000, Andrew Haley wrote:
> > Adding the ld instruction is an evil hack. If we were to vote, mine
> > would go to adding proper unwinder data for this function.
>
> The second patch is not adding the ld instruction, just moving it
> a few instructions earlier. And while it can be seen as a hack, that's the
> standard idiom ppc64 code uses in all linker generated code.
Whatever. I suspect that if you had produced only one patch rather
that two, the problem would be solved by now. :-)
Andrew.