This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR c++/24745: unpleasant warning for "if (NULL)"

Manuel López-Ibáñez writes:
 > (sorry for the duplicate, both of us forgot to CC gcc-patches)
 > 
 > On 27/01/07, Jason Merrill <jason@redhat.com> wrote:
 > > Manuel López-Ibáñez wrote:
 > >
 > > First, please use diff -p for generating patches; I find context diffs
 > > easier to read than unified.  Unfortunately, this requires some svn
 > > tweaking to make it use an external diff program.
 > >
 > 
 > I don't get this. I used diff -up following contribution guidelines.
 > Are you looking to the correct patch?
 > 
 > http://gcc.gnu.org/ml/gcc-patches/2007-01/txt00108.txt

Jason is asking you to prepare a patch using "diff -cp" because he
would find that easier to read.  In this case, I think that everyone
else would too.  He's not saying you've done anything wrong.

Andrew.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]