This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] typo patch


On Tue, 23 Jan 2007, Ralf Wildenhues wrote:
> Alright, thank you!  Here we go.

Thanks for this nice list of fixes.  I extracted those that I felt
sufficiently comfortable to put in and committed the patch below to
GCC SVN trunk and the 4.2 branch.¹

I will try to push this to the 4.1 branches as well.

Some comments on those pieces I did not commit:

 - Is "inferable" really more correct than "inferrable"?
 - In "logical @code{and} and logical @code{or}" I am not sure whether
   the markup really is right, or whether ``and''/``or'' might be better.

My recommendation is to consider the two issues above and resend the
remainders of your original large patch piecewise, one per file, so
that the appropriate maintainers can look into/discuss them more easily.

(Large patches such as this one have the tendency to scare away
potential reviewers. :-/)

Cheers,
Gerald

¹ In case anyone noticed: yes, I have been completely stupid, needing
several attempts to get the ChangeLog committed correctly. :-(  Sorry!

:REVIEWPATCH:

2007-01-28  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

        * doc/sourcebuild.texi: Add comma for clarity.
        * doc/extend.texi: Fix some typos.
        * doc/passes.texi: Likewise.
        * doc/cppinternals.texi: Likewise.
        * doc/c-tree.texi: Likewise.
        * doc/tree-ssa.texi: Likewise.
        * doc/install.texi: Likewise.

Index: sourcebuild.texi
===================================================================
--- sourcebuild.texi	(revision 121239)
+++ sourcebuild.texi	(working copy)
@@ -823,7 +823,7 @@
 @node Test Idioms
 @subsection Idioms Used in Testsuite Code
 
-In general C testcases have a trailing @file{-@var{n}.c}, starting
+In general, C testcases have a trailing @file{-@var{n}.c}, starting
 with @file{-1.c}, in case other testcases with similar names are added
 later.  If the test is a test of some well-defined feature, it should
 have a name referring to that feature such as
Index: extend.texi
===================================================================
--- extend.texi	(revision 121239)
+++ extend.texi	(working copy)
@@ -1290,7 +1290,7 @@
 duration by compound literals (which is not possible in ISO C99, because
 the initializer is not a constant).
 It is handled as if the object was initialized only with the bracket
-enclosed list if compound literal's and object types match.
+enclosed list if the types of the compound literal and the object match.
 The initializer list of the compound literal must be constant.
 If the object being initialized has array type of unknown size, the size is
 determined by compound literal size.
@@ -10123,7 +10123,7 @@
 @cindex pragma, diagnostic
 
 Modifies the disposition of a diagnostic.  Note that not all
-diagnostics are modifyiable; at the moment only warnings (normally
+diagnostics are modifiable; at the moment only warnings (normally
 controlled by @samp{-W...}) can be controlled, and not all of them.
 Use @option{-fdiagnostics-show-option} to determine which diagnostics
 are controllable and which option controls them.
@@ -11151,7 +11151,7 @@
 The implicit typename extension has been deprecated and is now
 removed from G++.
 
-The use of default arguments in function pointers, function typedefs and
+The use of default arguments in function pointers, function typedefs
 and other places where they are not permitted by the standard is
 deprecated and will be removed from a future version of G++.
 
Index: passes.texi
===================================================================
--- passes.texi	(revision 121239)
+++ passes.texi	(working copy)
@@ -223,7 +223,7 @@
 
 @item Lower control flow
 
-This pass flattens @code{if} statements (@code{COND_EXPR}) and
+This pass flattens @code{if} statements (@code{COND_EXPR})
 and moves lexical bindings (@code{BIND_EXPR}) out of line.  After
 this pass, all @code{if} statements will have exactly two @code{goto}
 statements in its @code{then} and @code{else} arms.  Lexical binding
@@ -324,7 +324,7 @@
 The resulting may-alias, must-alias, and escape analysis information
 is used to promote variables from in-memory addressable objects to
 non-aliased variables that can be renamed into SSA form.  We also
-update the @code{VDEF}/@code{VUSE} memory tags for non-renamable
+update the @code{VDEF}/@code{VUSE} memory tags for non-renameable
 aggregates so that we get fewer false kills.  The pass is located
 in @file{tree-ssa-alias.c} and is described by @code{pass_may_alias}.
 
Index: cppinternals.texi
===================================================================
--- cppinternals.texi	(revision 121239)
+++ cppinternals.texi	(working copy)
@@ -963,7 +963,7 @@
 on.
 
 Note that whilst we are inside the conditional block, @code{mi_valid} is
-likely to be reset to @code{false}, but this does not matter since the
+likely to be reset to @code{false}, but this does not matter since
 the closing @code{#endif} restores it to @code{true} if appropriate.
 
 Finally, since @code{_cpp_lex_direct} pops the file off the buffer stack
Index: c-tree.texi
===================================================================
--- c-tree.texi	(revision 121239)
+++ c-tree.texi	(working copy)
@@ -2193,7 +2193,7 @@
 
 @item FIX_TRUNC_EXPR
 These nodes represent conversion of a floating-point value to an
-integer.  The single operand will have a floating-point type, while the
+integer.  The single operand will have a floating-point type, while
 the complete expression will have an integral (or boolean) type.  The
 operand is rounded towards zero.
 
Index: tree-ssa.texi
===================================================================
--- tree-ssa.texi	(revision 121239)
+++ tree-ssa.texi	(working copy)
@@ -874,7 +874,7 @@
 Operands are updated as soon as the statement is finished via a call
 to @code{update_stmt}.  If statement elements are changed via
 @code{SET_USE} or @code{SET_DEF}, then no further action is required
-(ie, those macros take care of updating the statement).  If changes
+(i.e., those macros take care of updating the statement).  If changes
 are made by manipulating the statement's tree directly, then a call
 must be made to @code{update_stmt} when complete.  Calling one of the
 @code{bsi_insert} routines or @code{bsi_replace} performs an implicit
@@ -1109,9 +1109,9 @@
     @}
 @end smallexample
 
-There are 2 iterators which can be used. @code{FOR_EACH_IMM_USE_FAST} is used 
-when the immediate uses are not changed, ie. you are looking at the uses, but 
-not setting them.  
+There are 2 iterators which can be used. @code{FOR_EACH_IMM_USE_FAST} is
+used when the immediate uses are not changed, i.e., you are looking at the
+uses, but not setting them.  
 
 If they do get changed, then care must be taken that things are not changed 
 under the iterators, so use the @code{FOR_EACH_IMM_USE_STMT} and 
Index: install.texi
===================================================================
--- install.texi	(revision 121239)
+++ install.texi	(working copy)
@@ -909,7 +909,7 @@
 @item --disable-multilib
 Specify that multiple target
 libraries to support different target variants, calling
-conventions, etc should not be built.  The default is to build a
+conventions, etc.@: should not be built.  The default is to build a
 predefined set of them.
 
 Some targets provide finer-grained control over which multilibs are built

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]