Re: [PATCH] Make internal libgfortran I/O structure layout independent of -malign-double

[Steve Kargl <sgk at troutmask dot apl dot washington dot edu>]

On Fri, Jan 26, 2007 at 04:41:50PM -0800, Brooks Moses wrote:
> Fortran patches should be cc'ed to fortran@gcc.gnu.org.  Otherwise, the 
> relevant maintainers are unlikely to notice them.
> 

Thanks Brooks, I would not have seen this patch otherwise.

> Erik Schnetter wrote:
> >The enclosed patch ensures that the I/O parameter structures in
> >gfortran's run-time library have the same size and alignment,
> >independent of whether -malign-double is used or not, at least on
> >machines with 4-byte pointers which also have 8-byte integers
> >available.
> >
> >        PR fortran/30594
> >        * libgfortran/io/io.h: Permute struct members so that they
> >        remain aligned when -malign-double is used.
> >        * fortran/ioparm.def: Likewise.
> >        * testsuite/gfortran.dg/PR30594.f: New testcase.
> >

First, I agree with Andrew Pinski's assessment of the problem.
Second, the patch is incomplete because it breaks compatibility
with previous libraries, so you'll also need to bump the 
shared library version.  Note the version number was changed
on 17 Jan 07 and I'm not to thrilled with possibly bumping for
this and then again when library version comes into the tree.

-- 
Steve