This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't error on coverage mismatch by request


> On 1/22/07, Richard Guenther <richard.guenther@gmail.com> wrote:
> 
> >Ok, with this I managed to create a testcase that checks for properly
> >not-erroring.
> >But only with providing '-w' and silencing the extra inform () calls
> >in coverage.c
> >for inbibit_warnings==1.  As we do not support dg-error or dg-warning
> >for tree-prof.exp,
> >nor do we support an XFAIL somewhere (so I could declare profile
> >mismatch without
> >-Wcoverage-mismatch xfail...)
> >
> >Maybe better than nothing?

I think it is fine.  Of course if you want to go through additional pain
of teaching tree-prof.exp, you are very welcome to do so ;))
But in general profiling is not too much about warnings.

I would still preffer if we was able to simply default to profile
guessing when profile is unavilable but I see this is not 100% easy
right now, since many places still test global profile_info rather than
cfun->profile_status.  I will fix that incrementally.

The patch is OK.

Thanks,
Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]