This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)

From: FX Coudert <fxcoudert at gmail dot com>
To: Roger Sayle <roger at eyesopen dot com>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 20 Jan 2007 13:34:22 +0100
Subject: Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
References: <2125.208.41.78.162.1169251129.squirrel@mail.eyesopen.com>

2007-01-19 Roger Sayle <roger@eyesopen.com>

        * trans-intrinsic.c (gfc_conv_intrinsic_sign): New branchless
        implementation for the SIGN intrinsic with integral operands.
        (gfc_conv_intrinsic_minmax): Fix whitespace.

OK for 4.3 and 4.2, as is. Please also include in your commit the attached testcase, that includes Brooks' testcase and Steve's comment, as well as tests for the largest integer value of each integer kind.

For 4.1, it would be better to only add a call to gfc_evaluate_now. If you don't intend to do it, could you file a PR so that it doesn't get lost?

FX

Attachment: sign_1.f90
Description: Binary data

Follow-Ups:
- Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: Steve Kargl
- Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: Roger Sayle

References:
- [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]