This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] mark_hook in GTY?
- From: Ian Lance Taylor <iant at google dot com>
- To: Basile STARYNKEVITCH <basile at starynkevitch dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 19 Jan 2007 08:05:40 -0800
- Subject: Re: [PATCH] mark_hook in GTY?
- References: <20070118180612.GA29661@ours.starynkevitch.net>
Basile STARYNKEVITCH <basile@starynkevitch.net> writes:
> 2007-01-17 Basile Starynkevitch <basile@starynkevitch.net>
>
> * gcc/doc/gty.texi: documented the mark_hook option to GTY
> * gcc/gengtype.c: implemented mark_hook option.
> In struct write_types_data added skip_hooks. In functions
> walk_type, write_func_for_structure generated the mark hook if
> needed. In data ggc_wtd & pch_wtd initialized as needed the
> skip_hooks.
The ChangeLog format is wrong. Please look at the many existing
examples and/or read this web page:
http://www.gnu.org/prep/standards/html_node/Change-Logs.html
Please use complete, properly capitalized, sentences.
> @@ -1424,6 +1425,7 @@ struct walk_type_data
> options_p opt;
> const char *val;
> const char *prev_val[4];
> +
> int indent;
> int counter;
> struct fileloc *line;
Please remove this extraneous blank line.
Patch is OK with those changes. If you have any questions about the
ChangeLog format, please check with us before you commit.
Do you have a copyright assignment with the FSF? I do not see your
name in the copyright.list file and I can't tell whether you are
covered by some organization.
Ian