This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR 30437 [4.0/4.1/4.2/4.3 Regression] -Wno-all is rejected


Manuel López-Ibáñez wrote:
Wno-all is currently rejected on mainline. This simple patch fixes the
issue. However, a better fix would be to move Wall to common.opt but
let it be handled by each front-end. I was not able to implement this,
front-ends were not able to catch Wall, any suggestions ?

This patch bootstraps and does not generate new regressions. OK for mainline?

2007-01-15  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
   fortran/
  PR fortran/30437
  * lang.opt (Wall): Remove RejectNegative.

   testsuite/
  PR fortran/30437
  * gcc.dg/Wall-no.c: New.

Note that Fortran patches should be crossposted to fortran@gcc.gnu.org as well as to the gcc-patches@ list.


(Not only is this standard policy, but my impression is that many of the Fortran maintainers don't follow the main patches list, and they're even less likely to follow it closely enough to note patches that don't have "[Fortran]" in the subject line.)

Incidentally, I would also suggest that your testcase should be one that actually tests the implementation of the flag -- that is, it should have code that will generate a warning under normal circumstances, but not with -Wno-all.

- Brooks


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]