This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: update documentation for gcj-eclipse merge
>>>>> "Gerald" == Gerald Pfeifer <gerald@pfeifer.com> writes:
Gerald> Duh, I thought you'd go ahead and commit the patch with some changes,
Gerald> at least that's what I had ment to imply. =:-) Sorry for the delay.
:) No problem.
Gerald> The doc changes are fine. (Did you intentionally sort the ChangeLog
Gerald> entries in reverse order?)
Nope. I'm afraid I usually don't pay too much attention to the order
in which I put the entries.
Gerald> I cannot approve contrib/download_ecj, but let's just go for it, I'd
Gerald> say. No need to get overly anal here.
Ok, thanks.
>> +If you wish to modify @file{.java} files in libjava, you will need to
>> +configure with @option{--enable-java-maintainer-mode}, and you will need
>> +to have executables named @command{ecj1} and @command{gjavah} on your path.
Gerald> "in your path"? Not sure about this one.
I grepped and the existing docs seem to use "in" rather than "on".
So, I will make this change and check it all in. Thanks for your review.
Tom